Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating a FullViewingKey from a given SpendValidatingKey #432

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pacu
Copy link
Contributor

@pacu pacu commented Jul 31, 2024

builds atop #428

Allows creating a FullViewingKey from a given SpendValidatingKey and
from the other components which can be randomly generated, but there
may be some utility in specifying them too like supporting FROST backup
schemes that don't centralize spend authority

closes #431

see related #430

Copy link

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, from_sk_and_ak() alone would be enough for our use case. Added a comment about parameter naming.

src/keys.rs Outdated Show resolved Hide resolved
src/keys.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pacu pacu force-pushed the fvk-from-ask branch 2 times, most recently from d0e37ad to 6da15c1 Compare August 2, 2024 20:28
@pacu
Copy link
Contributor Author

pacu commented Aug 2, 2024

rebased and squashed

@pacu pacu requested a review from conradoplg August 3, 2024 22:19
Copy link

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As str4d mentioned, it's better to not link the FROST book which is non-normative, and wait for the ZIP to be finalized and add links to that later.

src/keys.rs Outdated Show resolved Hide resolved
Allows creating a FullViewingKey from a given SpendValidatingKey and
from the other components which can be randomly generated, but there
may be some utility in specifying them too like supporting FROST backup
schemes that don't centralize spend authority

closes zcash#431

see related zcash#430

PR Suggestions
Exposes FVK's components for FROST clients
Fix compile error on non-randomized flavor
@pacu
Copy link
Contributor Author

pacu commented Aug 17, 2024

Rebased with main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow creating a FullViewingKey from a given SpendValidatingKey.
2 participants